alamb commented on PR #780: URL: https://github.com/apache/arrow-rs-object-store/pull/780#issuecomment-4918037759
> My only nit is around strict URL parsing. I wonder if we should be as loose as possible when parsing URLs, rather than trying to determine what is “valid” ourselves. We can let the server make that decision. I am not quite sure what you are suggesting @kevinjqliu. Are you thinking maybe preserve the original URL in the builder rather than try and recreate it? If so that seems reasonable to me However, I think this PR is consistent with the exsting pattern in the code -- so we can proceed with this one while we can investigate more flexible/futureproof configuration as a follow on PR / issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
