alamb commented on code in PR #796:
URL:
https://github.com/apache/arrow-rs-object-store/pull/796#discussion_r3548089909
##########
dev/release/create-tarball.sh:
##########
@@ -53,21 +53,37 @@ fi
object_store_version=$1
rc=$2
-tag=v${object_store_version}
+tag=v${object_store_version}-rc${rc}
release=apache-arrow-object-store-rs-${object_store_version}
distdir=${SOURCE_TOP_DIR}/dev/dist/${release}-rc${rc}
tarname=${release}.tar.gz
tarball=${distdir}/${tarname}
url="https://dist.apache.org/repos/dist/dev/arrow/${release}-rc${rc}";
+if ! release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1
${tag} 2>/dev/null); then
+ echo "Cannot continue: unknown git tag: $tag"
+ exit 1
+fi
+
echo "Attempting to create ${tarball} from tag ${tag}"
-release_hash=$(cd "${SOURCE_TOP_DIR}" && git rev-list --max-count=1 ${tag})
+# create <tarball> containing the files in git at $release_hash
+# the files in the tarball are prefixed with {release} (e.g.
apache-arrow-object-store-rs-0.4.0)
+mkdir -p ${distdir}
+(cd "${SOURCE_TOP_DIR}" && git archive ${release_hash} --prefix ${release}/ |
gzip > ${tarball})
-if [ -z "$release_hash" ]; then
- echo "Cannot continue: unknown git tag: $tag"
-fi
+echo "Running rat license checker on ${tarball}"
+${SOURCE_DIR}/../../dev/release/run-rat.sh ${tarball}
+
+echo "Signing tarball and creating checksums"
Review Comment:
had to move this before the email so we can include the actual sha we are
voting on in the email
##########
dev/release/README.md:
##########
@@ -148,41 +149,8 @@ The `create-tarball.sh` script
### Vote on Release Candidate tarball
-Send an email, based on the output from the script to [email protected].
The email should look like
-
-```
-Draft email for [email protected] mailing list
-
----------------------------------------------------------
-To: [email protected]
-Subject: [VOTE][RUST] Release Apache Arrow Rust Object Store 0.11.1 RC1
-
-Hi,
-
-I would like to propose a release of Apache Arrow Rust Object
-Store Implementation, version 0.11.1.
-
-This release candidate is based on commit:
b945b15de9085f5961a478d4f35b0c5c3427e248 [1]
-
-The proposed release tarball and signatures are hosted at [2].
-
-The changelog is located at [3].
-
-Please download, verify checksums and signatures, run the unit tests,
-and vote on the release. There is a script [4] that automates some of
-the verification.
-
-The vote will be open for at least 72 hours.
-
-[ ] +1 Release this as Apache Arrow Rust Object Store
-[ ] +0
-[ ] -1 Do not release this as Apache Arrow Rust Object Store because...
-
-[1]:
https://github.com/apache/arrow-rs-object-store/tree/b945b15de9085f5961a478d4f35b0c5c3427e248
-[2]:
https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-object-store-rs-0.11.1-rc1/
-[3]:
https://github.com/apache/arrow-rs-object-store/blob/b945b15de9085f5961a478d4f35b0c5c3427e248/CHANGELOG.md
-[4]:
https://github.com/apache/arrow-rs-object-store/blob/main/dev/release/verify-release-candidate.sh
-```
+Send an email, based on the output from the script to [email protected].
+See an [example of how the email should
look](https://lists.apache.org/thread/29v3kjk5x6nlqrgt1kq6c7o8km0wn1w9).
Review Comment:
Follow the model from @Jefffrey did in arrow-rs
- https://github.com/apache/arrow-rs/pull/10283
##########
dev/release/create-tarball.sh:
##########
@@ -81,46 +97,33 @@ Hi,
I would like to propose a release of Apache Arrow Rust Object
Store Implementation, version ${object_store_version}.
-This release candidate is based on commit: ${release_hash} [1]
+This release candidate is based on commit: ${release_hash} [1].
+The SHA256 of the release candidate is: ${sha256}
The proposed release tarball and signatures are hosted at [2].
The changelog is located at [3].
+The release tracking issue is: [5]
Review Comment:
update to follow the arrow-rs model:
https://github.com/apache/arrow-rs/blob/4b54fe6f5a03fe196447c95c86cfbde5e66dcc8c/dev/release/create-tarball.sh#L105-L138
##########
dev/release/README.md:
##########
@@ -110,28 +110,29 @@ create a release candidate using the following steps.
Note you need to
be a committer to run these scripts as they upload to the apache `svn`
distribution servers.
-### Create git tag for the release:
+### Pick a Release Candidate (RC) number
+
+Pick numbers in sequential order, with `1` for `rc1`, `2` for `rc2`, etc.
+
+### Create git tag for the release candidate:
While the official release artifact is a signed tarball, we also tag the
commit it was created for convenience and code archaeology.
-Use a string such as `v0.4.0` as the `<version>`.
+Use a string such as `0.4.0` as the `<version>`.
Review Comment:
Also follows the arrow model
https://github.com/apache/arrow-rs/blob/4b54fe6f5a03fe196447c95c86cfbde5e66dcc8c/dev/release/README.md?plain=1#L108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
