Copilot commented on code in PR #50406: URL: https://github.com/apache/arrow/pull/50406#discussion_r3550135225
########## ci/scripts/python_build.bat: ########## @@ -134,6 +144,10 @@ pushd %SOURCE_DIR%\python %PYTHON_CMD% -m pip install -r requirements-build.txt || exit /B 1 @REM Build PyArrow -%PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv -C build.verbose=true . || exit /B 1 +%PYTHON_CMD% -m pip install --no-deps --no-build-isolation -vv ^ + -C build.verbose=true ^ + -C cmake.build-type=%CMAKE_BUILD_TYPE% ^ + -C cmake.define.CMAKE_C_FLAGS_RELWITHDEBINFO="%CMAKE_C_FLAGS_RELWITHDEBINFO%" ^ + -C cmake.define.CMAKE_CXX_FLAGS_RELWITHDEBINFO="%CMAKE_CXX_FLAGS_RELWITHDEBINFO%" . || exit /B 1 Review Comment: For the PyArrow build, `-C cmake.define.*` is not the pattern documented in `docs/source/developers/python/building.rst` for passing extra CMake cache entries (it recommends `-C cmake.args=...`). Using `cmake.args` here matches the other CI scripts (e.g. `python_wheel_windows_build.bat`) and avoids any ambiguity about whether `cmake.define` is intended for arbitrary `CMAKE_*` variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
