ntjohnson1 commented on PR #790: URL: https://github.com/apache/arrow-rs-object-store/pull/790#issuecomment-4926721714
Thanks for an in-depth review as always. > I also don't understand what is special about Hugging face -- does this mean S3 requests that return redirect's aren't working at all (for any provider)? I suspect the more general title makes more sense. I'm not sure how popular the redirects are for s3 like apis. We mostly just use the major supported ones here today but are explore R2/B2 etc starting with HF buckets. That's weird Codex had such a hard time digging through to the root cause. Claude seemed to stumble on it pretty easily, next time I can provide the better trace through for easier ability to verify. > What I am most worried about is that removing the Host header from the request headers will mess up some other existing users. I'm kind of relying on the existing tests CI to cover this here. Alternatively I could try to include this branch as a patch on a system we use with aws to see if things still go through correctly over there (but would probably take some time to get that setup). I don't have super in depth familiarity here to gauge the risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
