Copilot commented on code in PR #50452:
URL: https://github.com/apache/arrow/pull/50452#discussion_r3553211477


##########
ruby/red-arrow-format/lib/arrow-format/array.rb:
##########
@@ -537,7 +537,14 @@ class DurationArray < TemporalArray
   end
 
   class VariableSizeBinaryArray < Array
-    def initialize(size, validity_buffer, offsets_buffer, values_buffer)
+    include BufferAlignable
+    def initialize(*args)
+      if args.size == 1
+        args = build_data(args.first)
+      end
+

Review Comment:
   `initialize` now accepts `*args` but doesn't validate the final argument 
count. Calls like `new(size, validity_buffer)` will silently set 
`@offsets_buffer`/`@values_buffer` to `nil` and fail later with less clear 
errors. This is inconsistent with `PrimitiveArray`, which raises 
`ArgumentError` up front for invalid arity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to