AntoinePrv commented on code in PR #50422:
URL: https://github.com/apache/arrow/pull/50422#discussion_r3553250357
##########
cpp/src/arrow/util/rle_encoding_test.cc:
##########
@@ -1257,6 +1404,19 @@ void DoTestGetBatchSpacedRoundtrip() {
CheckRoundTrip<ArrowType>(*array, case_.bit_width, /* spaced= */ false,
/* parts= */ 3);
+ // Tests for Advance
+ CheckAdvance<ArrowType>(*array, case_.bit_width);
+ CheckAdvance<ArrowType>(*array->Slice(1), case_.bit_width);
+
+ // Tests for CountUpTo, counting a value present in the data (the first
one)
+ // and a value that may not be (the max encodable one).
+ const auto first = static_cast<T>(
+ static_cast<const typename
TypeTraits<ArrowType>::ArrayType&>(*array).Value(0));
+ const auto max_value = static_cast<T>((T{1} << (case_.bit_width - 1)) - 1);
Review Comment:
My bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
