fornwall opened a new pull request, #4492: URL: https://github.com/apache/arrow-adbc/pull/4492
`TestSqlQueryFloats` and `TestSqlSchemaFloats` hardcoded `SELECT CAST(1.5 AS FLOAT)`, whose `FLOAT` type name is not valid in every SQL dialect (GoogleSQL in BigQuery supports only `FLOAT64` - Spanner also `FLOAT32`). Introduce a `DriverQuirks::FloatCastTypeName()` quirk defaulting to `FLOAT` and build the cast SQL from it, so existing drivers run byte-identical SQL while other dialects can override the type name. The tests assert only the returned Arrow type and value (1.5), which are unaffected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
