kou commented on code in PR #50450:
URL: https://github.com/apache/arrow/pull/50450#discussion_r3555915489
##########
cpp/CMakeLists.txt:
##########
@@ -362,6 +362,10 @@ if(CMAKE_VERSION VERSION_LESS 3.18)
else()
set(CXX_LINKER_SUPPORTS_VERSION_SCRIPT TRUE)
endif()
+elseif(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Review Comment:
All MSVC like compilers behave like
https://github.com/apache/arrow/pull/50450#issuecomment-4929810477 , right?
(All symbols are hidden by default.)
If so, can we use `elseif(MSVC)` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
