goutamadwant commented on code in PR #1192:
URL: https://github.com/apache/arrow-java/pull/1192#discussion_r3556098554
##########
vector/src/test/java/org/apache/arrow/vector/TestVariableWidthViewVector.java:
##########
@@ -540,6 +540,26 @@ public void testSizeOfViewBufferElements() {
}
}
+ @ParameterizedTest
+ @MethodSource({"vectorCreatorProvider"})
+ public void testSetSafeEmptyValueAtViewBufferBoundary(
Review Comment:
@mbutrovich added coverage for both additional paths: `setNull` and
`setValueCount`/`fillEmpties` at the view-buffer boundary. The production fix
is unchanged and his just closes the missing regression coverage. Let me know.
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
