alamb opened a new issue, #798:
URL: https://github.com/apache/arrow-rs-object-store/issues/798

   **Describe the bug**
   Clippy job is failing in main
   
   I first noticed this on 
https://github.com/apache/arrow-rs-object-store/actions/runs/29029147710/job/86360506279?pr=790
   
   I suspect it is related to the release of 
https://blog.rust-lang.org/2026/07/09/Rust-1.97.0/ 
   
   **To Reproduce**
   run `rustup update` 
   
   
   ```
   cargo clippy --features azure -- -D warnings
   ```
   
   Then 
   ```
     cargo clippy --features azure -- -D warnings
     shell: sh -e {0}
       Checking object_store v0.14.0 
(/__w/arrow-rs-object-store/arrow-rs-object-store)
   error: redundant reference in `format!` argument
       --> src/azure/builder.rs:1269:73
        |
   1269 |                         
format!("https://{}.blob.fabric.microsoft.com";, &account_name)
        |                                                                       
  ^^^^^^^^^^^^^ help: remove the redundant `&`: `account_name`
        |
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
        = note: `-D clippy::useless-borrows-in-formatting` implied by `-D 
warnings`
        = help: to override `-D warnings` add 
`#[allow(clippy::useless_borrows_in_formatting)]`
   
   error: redundant reference in `format!` argument
       --> src/azure/builder.rs:1271:74
        |
   1271 |                     false => 
format!("https://{}.blob.core.windows.net";, &account_name),
        |                                                                       
   ^^^^^^^^^^^^^ help: remove the redundant `&`: `account_name`
        |
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
   
   error: redundant reference in `format!` argument
      --> src/azure/credential.rs:447:9
       |
   447 |         &AZURE_VERSION.to_str().unwrap(), // signed version
       |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant 
`&`: `AZURE_VERSION.to_str().unwrap()`
       |
       = help: for further information visit 
https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
   
   error: redundant reference in `format!` argument
      --> src/azure/credential.rs:499:9
       |
   499 |         &AZURE_VERSION.to_str().unwrap(), // signed version
       |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the redundant 
`&`: `AZURE_VERSION.to_str().unwrap()`
       |
       = help: for further information visit 
https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#useless_borrows_in_formatting
   
   error: could not compile `object_store` (lib) due to 4 previous errors
   ```
   
   **Expected behavior**
   Should pass CI
   
   I think we should also pin the toolchain.toml so we don't get unexpected 
clippy updates
   
   **Additional context**
   <!--
   Add any other context about the problem here.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to