fallintoplace opened a new pull request, #926: URL: https://github.com/apache/arrow-go/pull/926
Data.SetDictionary released the existing dictionary before retaining the replacement. Replacing a dictionary with the same pointer while the parent held the final reference could therefore clear the dictionary before resurrecting its reference. This retains the validated replacement first, swaps it into the Data object, then releases the previous dictionary. It also handles nil input and reports an explicit panic for an invalid dictionary data implementation. Tests: - go test ./arrow/array -run 'TestData(SetDictionaryWithSamePointerRetainsDictionary|ResetClearsDictionary)' - go test ./arrow/array - go test ./arrow/... -run '^$' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
