zeroshade commented on code in PR #922:
URL: https://github.com/apache/arrow-go/pull/922#discussion_r3566723457
##########
arrow/array/struct.go:
##########
@@ -61,6 +61,9 @@ func NewStructArrayWithFieldsAndNulls(cols []arrow.Array,
fields []arrow.Field,
}
length := cols[0].Len()
+ if err := validateStructArrayOffset(offset, length); err != nil {
Review Comment:
The existing offset-validation test only exercises
`NewStructArrayWithNulls`; since this fix also guards
`NewStructArrayWithFieldsAndNulls`, please add a mirrored invalid-offset case
for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
