ByteBaker opened a new pull request, #10327: URL: https://github.com/apache/arrow-rs/pull/10327
# Which issue does this PR close? - Closes #1002. # Rationale for this change `parquet_derive` is a proc-macro crate, but it currently has a normal dependency on `parquet`. This causes `parquet` and its dependency graph to be compiled for the proc-macro host even though the macro only needs to emit references to Parquet APIs. As discussed in the issue, derive crates such as `serde_derive` avoid depending normally on the runtime crate. The generated code is instead resolved against the consumer's direct dependency. # What changes are included in this PR? - Replaces compile-time use of `parquet::basic::Type` with a private physical-type classifier. - Keeps generated `::parquet::...` paths unchanged. - Removes `parquet` as a normal dependency of `parquet_derive`. - Retains `parquet` as a dev-dependency for doctests. - Removes the now-unnecessary `extern crate parquet`. # Are these changes tested? Yes. Ran: - `cargo test -p parquet_derive` passed. - `cargo test -p parquet_derive_test` passed. - `cargo clippy -p parquet_derive --all-features -- -D warnings`. - `cargo fmt --all -- --check`. - `cargo tree -p parquet_derive --edges normal`, confirming its normal dependencies are now limited to `proc-macro2`, `quote`, and `syn`. # Are there any user-facing changes? None. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
