cyb70289 commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r632209010
##########
File path: docs/source/cpp/compute.rst
##########
@@ -260,6 +260,10 @@ an ``Invalid`` :class:`Status` when overflow is detected.
+--------------------------+------------+--------------------+---------------------+
| Function name | Arity | Input types | Output type
|
+==========================+============+====================+=====================+
+| abs | Unary | Numeric | Numeric
|
Review comment:
We also have to add compute functions manually to python api doc
https://github.com/apache/arrow/blob/master/docs/source/python/api/compute.rst
##########
File path: cpp/src/arrow/util/int_util_internal.h
##########
@@ -63,9 +63,9 @@ OPS_WITH_OVERFLOW(DivideWithOverflow, div)
#undef OP_WITH_OVERFLOW
#undef OPS_WITH_OVERFLOW
-// Define functions NegateWithOverflow with the signature `bool(T u, T* out)`
-// where T is a signed integer type. On overflow, these functions return true.
-// Otherwise, false is returned and `out` is updated with the result of the
+// Define functions NegateWithOverflow with the signature
+// `bool(T u, T* out)` where T is a signed integer type. On overflow, these
functions
+// return true. Otherwise, false is returned and `out` is updated with the
result of the
Review comment:
Nit: is this intended or spurious change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
