dmitry-chirkov-dremio commented on code in PR #40031:
URL: https://github.com/apache/arrow/pull/40031#discussion_r3581645355
##########
cpp/src/gandiva/tests/projector_test.cc:
##########
@@ -51,6 +51,74 @@ class TestProjector : public ::testing::Test {
arrow::MemoryPool* pool_;
};
+TEST_F(TestProjector, TestCastDecimalToString) {
Review Comment:
This test seems a bit too weak for the regression it is trying to protect.
It only checks that `Projector::Make(...)` succeeds and that the result was not
built from cache, but it never evaluates the expression.
Given the risk here is missing helper registration for decimal-to-string
code paths, I’d feel better with an actual `Evaluate(...)` assertion that
exercises the generated code. The timezone-aware `castTIMESTAMP_utf8` path may
also need similar coverage for the same reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
