fallintoplace opened a new pull request, #941:
URL: https://github.com/apache/arrow-go/pull/941

   ### Rationale for this change
   
   The unary bearer interceptor used a prefix check and then sliced past an 
assumed space. An authorization value containing exactly `Bearer` could 
therefore panic, while values such as `BearerX token` were treated as bearer 
credentials.
   
   ### What changes are included in this PR?
   
   Parse the authorization scheme and credential separately, require the exact 
Bearer scheme, and trim additional spaces before the credential.
   
   ### Are these changes tested?
   
   Yes. Regression coverage includes missing credentials, malformed schemes, 
and valid credentials separated by multiple spaces. `go test ./arrow/flight` 
passes.
   
   ### Are there any user-facing changes?
   
   Malformed bearer headers now fail authentication instead of panicking. 
Multiple spaces after the scheme are accepted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to