Copilot commented on code in PR #49276:
URL: https://github.com/apache/arrow/pull/49276#discussion_r3597019567
##########
r/tests/testthat/test-dataset-write.R:
##########
@@ -596,11 +596,11 @@ test_that("write_dataset checks for format-specific
arguments", {
)
dst_dir <- make_temp_dir()
expect_snapshot(
- write_dataset(df, dst_dir, format = "feather", compression = "snappy"),
+ write_dataset(df, dst_dir, format = "ipc", compression = "snappy"),
error = TRUE
)
expect_snapshot(
- write_dataset(df, dst_dir, format = "feather", nonsensical_arg =
"blah-blah"),
+ write_dataset(df, dst_dir, format = "ipc", nonsensical_arg = "blah-blah"),
error = TRUE
)
Review Comment:
`test_that("write_dataset checks for format-specific arguments")` now
snapshots the exact same call twice: `write_dataset(df, dst_dir, format =
"ipc", nonsensical_arg = "blah-blah")` appears here and again a few lines
later. This duplicates snapshot output without increasing coverage and makes
future snapshot updates noisier. Remove one of the duplicate
`expect_snapshot()` blocks (and update the snapshot file accordingly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
