kentkwu opened a new pull request, #4537:
URL: https://github.com/apache/arrow-adbc/pull/4537

   ### Summary
   
   Allows creating `AdbcDatabase` without an explicit `driver` option when 
`databaseOptions.uri` contains a URI that identifies the driver, or when 
`databaseOptions.profile` specifies a connection profile
   
   **Before**
   ```ts
   // before: driver was required
   new AdbcDatabase({ driver: 'sqlite', databaseOptions: { uri: ':memory:' } })
   ```
   
   **After**
   ```ts
   // now: driver can be omitted when uri carries the scheme
   new AdbcDatabase({ databaseOptions: { uri: 'sqlite::memory:' } })
   
   // now: driver can be omitted with a bare profile name
   new AdbcDatabase({ databaseOptions: { profile: 'my_profile' } })
   ```
   
   Specifying more than one profile resolution path results in an error
   
   ```ts
   // will error
   new AdbcDatabase({ databaseOptions: { profile: 'p1', uri: 'profile://p2' } })
   ```
   
   **Test Plan**
   ```
   npm build
   npm test
   ```
   
   Closes #4533 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to