bit2swaz commented on PR #10324: URL: https://github.com/apache/arrow-rs/pull/10324#issuecomment-5004878623
yeah, agreed that its not worth fast tracking a major just for this i think its worth flagging that the breaking part is optional tho. i think there's two ways to close the soundness hole: 1. non-breaking: keep the current `-> GenericStringArray<O>` signature, call `try_new` internally and `.expect()` on it. a misbehaving engine panics instead of hitting UB. panic-on-broken-engine is sound and ships in a minor and the honest `GeneralPurpose` path never panics 2. breaking: the `Result` version this PR already has. cleaner api and it waits for the next major so you dont actually have to pick between "fast track a major" and "leave UB in a released version". option 1 fixes the UB now and the `Result` cleanup can ride the next major on its own schedule more than happy to reshape the PR to the panic version if youd rather ship it in a minor, or leave it as `Result` and let it wait. which one do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
