WillAyd commented on code in PR #905:
URL: https://github.com/apache/arrow-nanoarrow/pull/905#discussion_r3604802252
##########
meson.build:
##########
@@ -263,13 +263,14 @@ if get_option('tests').enabled()
# Similarly code coverage has a built in option users should use instead
# https://mesonbuild.com/Unit-tests.html#coverage
- arrow_dep = dependency('arrow', include_type: 'system', required: false)
if get_option('tests_with_arrow').enabled()
- if arrow_dep.found()
- test_cpp_args += ['-DNANOARROW_BUILD_TESTS_WITH_ARROW']
- else
- warning('tests_with_arrow option enabled but could not find Arrow')
- endif
+ # When tests_with_arrow is enabled, Arrow is required. Use pkg-config
first,
+ # then fall back to building from the wrapdb subproject if not found.
+ arrow_dep = dependency('arrow')
Review Comment:
```suggestion
arrow_dep = dependency('arrow', include_type: 'system')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
