kevinjqliu commented on PR #781: URL: https://github.com/apache/arrow-rs-object-store/pull/781#issuecomment-5008586172
I verified this with my own azure storage account, it works great. Thanks for adding this! I think there are a few follow-ups could make the delegation-key cache more flexible and robust: - Make `DELEGATION_KEY_VALIDITY` optionally configurable so users can limit how long reusable keys remain valid. This setting should never shorten a key below the requested SAS lifetime. - Remove the fixed `DELEGATION_KEY_MIN_TTL`. Azure returns the key’s actual `SignedExpiry`, so cache it and reuse the key only when `SignedExpiry` is later than the requested SAS expiry. Otherwise, fetch a new key. - Treat Azure’s returned `SignedStart` and `SignedExpiry` as authoritative. Return a clear error if they are malformed or do not cover the full SAS lifetime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
