hiroyuki-sato commented on code in PR #50536:
URL: https://github.com/apache/arrow/pull/50536#discussion_r3607687730
##########
ci/scripts/python_test.sh:
##########
@@ -69,9 +71,9 @@ export PYARROW_TEST_PARQUET_ENCRYPTION
export PYARROW_TEST_S3
# Testing PyArrow
-pytest -r s ${PYTEST_ARGS} --pyargs pyarrow
+pytest -r s "${PYTEST_ARGS}" --pyargs pyarrow
# Testing RST documentation examples (if PYTEST_RST_ARGS is set)
if [ -n "${PYTEST_RST_ARGS}" ]; then
- pytest ${PYTEST_RST_ARGS} ${arrow_dir}/docs/source/python
+ pytest "${PYTEST_RST_ARGS}" "${arrow_dir}/docs/source/python"
Review Comment:
Thanks! I’ve updated it as follows
```bash
if [ -n "${PYTEST_RST_ARGS}" ]; then
# Convert the space-separated options into a Bash array.
# This avoids ShellCheck SC2086 and preserves argument boundaries.
read -r -a PYTEST_RST_ARGS_ARRAY <<< "$PYTEST_RST_ARGS"
pytest "${PYTEST_RST_ARGS_ARRAY[@]}" "${arrow_dir}/docs/source/python"
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
