Rich-T-kid commented on code in PR #10277:
URL: https://github.com/apache/arrow-rs/pull/10277#discussion_r3608688855
##########
arrow-ipc/Cargo.toml:
##########
@@ -52,7 +52,7 @@ lz4 = ["lz4_flex"]
[dev-dependencies]
criterion = { workspace = true }
tempfile = "3.3"
-tokio = "1.43.0"
+tokio = { version = "1.43.0", features = ["io-util", "macros", "rt"] }
Review Comment:
Does this count as increasing our dependencies? Tokio was already imported,
so I think this is fine
##########
arrow-ipc/src/writer.rs:
##########
@@ -135,6 +135,175 @@ impl<'a> IpcBodySink<'a> {
}
}
+/// Destination for a complete framed IPC message.
Review Comment:
this should be a follow up so that its easier to review. I created this
issue to track it https://github.com/apache/arrow-rs/issues/10373
##########
arrow-ipc/src/writer.rs:
##########
@@ -135,6 +135,175 @@ impl<'a> IpcBodySink<'a> {
}
}
+/// Destination for a complete framed IPC message.
Review Comment:
we should also add benchmarks for the stream encoder to catch regressions in
the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
