amoeba commented on code in PR #4527:
URL: https://github.com/apache/arrow-adbc/pull/4527#discussion_r3610930728
##########
docs/source/driver/flight_sql.rst:
##########
@@ -266,15 +227,9 @@ Database options
If unset, the ``adbcfile`` exporter writes traces under the user's
configuration directory in:
- - Windows: ``%APPDATA%\.adbc\traces``
- - macOS: ``~/Library/Application Support/.adbc/traces``
- - Linux: ``$XDG_CONFIG_HOME/.adbc/traces`` or ``~/.config/.adbc/traces``
-
- .. note::
-
- These default paths reflect the current implementation. See
- `issue #4501 <https://github.com/apache/arrow-adbc/issues/4501>`_
- for the planned config-path redesign.
+ - Windows: ``%APPDATA%\ADBC\Traces``
+ - macOS: ``~/Library/Application Support/ADBC/Traces``
+ - Linux: ``$XDG_CONFIG_HOME/adbc/traces`` or ``~/.config/adbc/traces``
Review Comment:
I'm not sure if these dirs are the right call here. Since traces are more
like log files than config files, shouldn't traces go in the equivalent of
$XDG_DATA_HOME? I'm still a +1 on this PR but I wonder if there's any benefit
to storing traces in a non-roaming location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
