lidavidm commented on issue #1755:
URL: https://github.com/apache/arrow-adbc/issues/1755#issuecomment-5018873677
To summarize, I think there's a variety of things that need to be done here:
- Expand integration testing to cover Postgres-compatible databases
- It appears people have
[tested](https://github.com/columnar-tech/adbc-quickstarts/tree/main/python/postgresql)
all of the following: CedarDB, Citus, CockroachDB, CrateDB, Greenplum, Neon,
ParadeDB, TimescaleDB, Yellowbrick, YugabyteDB. AlloyDB has not been tested
AFAIK
- If we change our queries or approach, it would be best to verify
(ideally automatically) that we haven't broken compatibility (or explicitly
note that some DBs are not fully compatible), so if we can add some of these to
CI, that would be ideal
- Redshift is explicitly out-of-scope and IIRC it is known that
Materialize is not compatible
- Consider if we can simply optimize the query (as @vaefremov95 suggests)
- The optimized query is subject to the same compatibility question,
although again, the driver is already not necessarily compatible with all
Postgres-"compatible" systems
- Consider loading the OID -> typrecv mapping dynamically
- Consider if we can hardcode the OID -> typrecv mapping for core data
types and avoid the lookup unless you actually query a composite or other
user-defined type; this depends on all Postgres versions (and other databases)
having a consistent mapping
@Mandukhai-Alimaa if you still want to work on this, it might be best to
break this down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
