pitrou commented on code in PR #50549:
URL: https://github.com/apache/arrow/pull/50549#discussion_r3614997930
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2567,8 +2567,15 @@ if(ARROW_MIMALLOC)
"-DCMAKE_C_FLAGS=${MIMALLOC_C_FLAGS}"
"-DCMAKE_INSTALL_PREFIX=${MIMALLOC_PREFIX}"
-DMI_INSTALL_TOPLEVEL=ON
+ # Don't override default malloc
-DMI_OVERRIDE=OFF
+ -DMI_OSX_INTERPOSE=OFF
+ -DMI_OSX_ZONE=OFF
+ # Allow usage through dlopen (i.e. when libarrow.so itself is dlopen'ed)
-DMI_LOCAL_DYNAMIC_TLS=ON
+ # GH-50428: Make sure several mimalloc instances can cohabit in the same
process
+ # (also
https://github.com/microsoft/mimalloc/issues/1327#issuecomment-4964140817)
+ -DMI_TLS_MODEL_THREAD_LOCAL=ON
Review Comment:
Ouch, you're right, I was blindly copying the suggestion from the mimalloc
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
