alamb commented on a change in pull request #328:
URL: https://github.com/apache/arrow-datafusion/pull/328#discussion_r632736152
##########
File path: datafusion/src/physical_plan/functions.rs
##########
@@ -1358,6 +1366,18 @@ impl fmt::Display for ScalarFunctionExpr {
}
}
+/// null columnar values are implemented as a null array in order to pass batch
+/// num_rows
+type NullColumnarValue = ColumnarValue;
+
+impl TryFrom<&RecordBatch> for NullColumnarValue {
+ type Error = DataFusionError;
+ fn try_from(batch: &RecordBatch) -> Result<Self> {
Review comment:
It seems to me this function is infallible (aka it never returns error,
but always returns `Ok`).
Perhaps we could implement `From` instead of `TryFrom`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
