alamb commented on code in PR #10301:
URL: https://github.com/apache/arrow-rs/pull/10301#discussion_r3617230606
##########
arrow-buffer/src/pool.rs:
##########
@@ -147,6 +147,77 @@ impl MemoryReservation for Tracker {
}
}
+/// This is a wrapper for the reservation so we can standardize on changing
+/// and avoid race conditions in memory accounting
+#[derive(Debug, Default)]
+pub struct TrackedReservation {
Review Comment:
Is this `pub` in the sense that it can be used outside this crate? If so I
think we should document it more, and be clear if we need to expand the public
API -- if it is meant to be internal, perhaps we can mark it as `pub(crate)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
