sdf-jkl commented on PR #10318:
URL: https://github.com/apache/arrow-rs/pull/10318#issuecomment-5027606769
@alamb upon further inspection it seems like we never really allowed writing
shredded `VariantArray` with an empty `value` field when _used correctly_.
`shred_variant` always returned a `value` field:
https://github.com/apache/arrow-rs/blob/a16c4584d1fd194d236c1757e92ebcb0837cb0f0/parquet-variant-compute/src/shred_variant.rs#L103-L107
`variant_get`/`try_new` would propagate whatever the `value` field was
without checking.
So the only way to construct a new shredded `VariantArray` from scratch with
the field omitted would be via `from_parts`.
----
Regardless, other readers are lenient
(https://github.com/apache/parquet-format/pull/591#issuecomment-4939397357), so
I think it's a good idea to support that -
https://github.com/apache/arrow-rs/pull/10318/commits/2738018fe15afb47096ddd88800618c78d13cc3a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
