wjwithagen commented on PR #906:
URL: https://github.com/apache/arrow-nanoarrow/pull/906#issuecomment-5033260014
'mmmm,
Not sure if this is the correct fix for FreeBSD.....
But I have my findings from porting Ceph to FreeBSD where Functions calls
that under FreeBSD return ENOATTR and Ceph actually tests for ENODATA. These
are mostly functions handeling (ex)atributes....
So hence my suggestion with FreeBSD to
```
*** /usr/include/errno.h Mon Oct 3 02:05:43 2016
--- /usr/srcs/head/src/sys/sys/errno.h Sun Aug 21 18:25:05 2016
***************
*** 164,170 ****
#define ECANCELED 85 /* Operation canceled */
#define EILSEQ 86 /* Illegal byte sequence */
#define ENOATTR 87 /* Attribute not found */
- #define ENODATA 87 /* Attribute not found */
#define EDOOFUS 88 /* Programming error */
#endif /* _POSIX_SOURCE */
--- 164,169 ----
```
If you fix it in a different way:
- compilation will work
- program will run
- but attribute errors will not be noticed
- wierd errors will need serious debugging
So you atleast need to look at the function that it return got tested agains
`ENODATA` to make sure that tests actually will work as expected.... And I'm
pretty sure that just picking a random value will not add to really fiing the
problem in Apache tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
