Jefffrey commented on code in PR #10368:
URL: https://github.com/apache/arrow-rs/pull/10368#discussion_r3622653595
##########
arrow/benches/zip_kernels.rs:
##########
@@ -236,6 +241,26 @@ fn bench_zip_on_input_generator(c: &mut Criterion,
input_generator: &impl InputG
&array_2_10pct_nulls,
);
+ for (mask_description, mask) in &masks {
Review Comment:
are these new benchmarks strictly necessary? they seem to add quite a lot of
new benchmarks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
