Tpt commented on PR #10400: URL: https://github.com/apache/arrow-rs/pull/10400#issuecomment-5034879554
> however with the changes of this PR i get a compile error: Indeed. This is likely because of a change in type inference: when a function like `BinaryArray::from_vec` is called (before this MR) Rust will try to do the needed casts to make the call work whereas with `BinaryArray::from` (after this MR) Rust will try to find a compatible `From` implementation on the input types without casts and fail. An option is to add more `From` implementations to the underlying type. I have just done it in 21196ef3c4df00cbce67bf478454a8526c417919 With it the MR has the upside of making `create_array!(Binary, [b"foo"])` work but breaks `create_array!(Binary, [None])` that needs to be rewritten `create_array!(Binary, [None::<&[u8]>])`. What do you think about it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
