HannaWeissberg commented on code in PR #50483:
URL: https://github.com/apache/arrow/pull/50483#discussion_r3629882963
##########
cpp/src/arrow/csv/parser.cc:
##########
@@ -561,8 +563,17 @@ class BlockParserImpl {
values_size_ = 0;
size_t total_view_length = 0;
+ block_has_nul_ = false;
for (const auto& view : views) {
total_view_length += view.length();
+#if defined(ARROW_HAVE_SSE4_2) && (defined(__x86_64__) || defined(_M_X64))
+ // Only the SSE4.2 bulk filter is affected by embedded NUL bytes,
+ // so only scan for them when that filter is available.
+ if (!block_has_nul_ && !view.empty() &&
+ memchr(view.data(), '\0', view.length()) != nullptr) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
