C-Loftus commented on code in PR #969:
URL: https://github.com/apache/arrow-go/pull/969#discussion_r3632506984
##########
parquet/pqarrow/schema.go:
##########
@@ -129,6 +129,13 @@ type ExtensionCustomParquetType interface {
ParquetLogicalType() schema.LogicalType
}
+// ExtensionParquetLogicalType is an interface that Arrow ExtensionTypes may
+// implement to specify how a Parquet LogicalType maps back to an Arrow
+// ExtensionType when converting a Parquet schema to an Arrow schema.
+type ExtensionParquetLogicalType interface {
+ ArrowTypeFromParquet(logical schema.LogicalType, storageType
arrow.DataType) (arrow.ExtensionType, error)
+}
Review Comment:
I agree with this comment ideally although isn't
`ExtensionCustomParquetType` already in the public API so it would not be
possible to change that? As such I think I am a bit stumped on how to name this
with breaking existing extension type resolution.
i.e. to my understanding I don't think I could change it to be a symmetric
pair since there is already a `ParquetLogicalType()` function which doesn't
have a clear symmetric parallel. Feel free to suggest any name if I am
overlooking a good option.
https://github.com/apache/arrow-go/blob/main/parquet/pqarrow/schema.go#L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
