STiFLeR7 commented on code in PR #10407:
URL: https://github.com/apache/arrow-rs/pull/10407#discussion_r3635753110
##########
arrow-avro/src/reader/vlq.rs:
##########
@@ -29,19 +31,30 @@ pub struct VLQDecoder {
impl VLQDecoder {
/// Decode a signed long from `buf`
- pub fn long(&mut self, buf: &mut &[u8]) -> Option<i64> {
+ ///
+ /// Returns `Err` if `buf` starts with more than 10 continuation bytes
without a
+ /// terminator, which would otherwise overflow the accumulated `u64`
(matching the
+ /// bound already enforced by [`read_varint_array`] for the stateless
decoders below).
Review Comment:
Fixed in b57884b — reworded to acknowledge the cross-call accumulation and
reference `i64` instead of the internal `u64`. Thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
