hiroyuki-sato commented on code in PR #50610:
URL: https://github.com/apache/arrow/pull/50610#discussion_r3636083755
##########
ci/scripts/r_deps.sh:
##########
@@ -43,15 +43,15 @@ fi
# install.packages() emits warnings if packages fail to install,
# but we want to error/fail the build.
# options(warn=2) turns warnings into errors
-${R_BIN} -e "options(warn=2); install.packages('remotes');
remotes::install_cran(c('glue', 'rcmdcheck', 'sys'));
remotes::install_deps(INSTALL_opts = '"${INSTALL_ARGS}"')"
+"${R_BIN}" -e "options(warn=2); install.packages('remotes');
remotes::install_cran(c('glue', 'rcmdcheck', 'sys'));
remotes::install_deps(INSTALL_opts = '""${INSTALL_ARGS}""')"
Review Comment:
Thank you for your comment.
I tried your suggested change, but the CI failed.
https://github.com/apache/arrow/actions/runs/29978332833
As I understand it, the original expression is split into three parts. In
this case, I think they can be combined into a single string without the extra
double quotes.
`"remotes::install_deps(dependencies = TRUE, INSTALL_opts =
'"${INSTALL_ARGS}"')"`
* `"remotes::install_deps(dependencies = TRUE, INSTALL_opts = '"`
* `${INSTALL_ARGS}`
* `"')"`
After removing the double quotes, the CI passed. What do you think of this
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
