nsrip-dd commented on PR #984: URL: https://github.com/apache/arrow-go/pull/984#issuecomment-5058872898
> Looks good to me, but is there a deterministic way to confirm via tests? Or do we have to wait until we follow-up with the R28/R18 fixes? I added https://github.com/apache/arrow-go/pull/984/changes/40aedb64acd2c560bfabb6470a6ba50ea6bf83d4, which reliably catches the issue for _memset_neon on my laptop. It's a bit verbose but I'm not sure how much simpler it can be. I opted to use `go tool pprof` rather than `github.com/google/pprof` so we don't get a new dependency. We could write similar tests for the other functions this PR fixes. Let me know if this approach is okay with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
