justing-bq commented on code in PR #50562:
URL: https://github.com/apache/arrow/pull/50562#discussion_r3639903374
##########
cpp/src/arrow/flight/sql/odbc/odbc_api.cc:
##########
@@ -1621,8 +1629,10 @@ SQLRETURN SQLDescribeCol(SQLHSTMT stmt, SQLUSMALLINT
column_number, SQLWCHAR* co
case SQL_INTERVAL_MINUTE_TO_SECOND:
case SQL_INTERVAL_HOUR_TO_SECOND:
case SQL_INTERVAL_DAY_TO_SECOND: {
+ // decimal_digits_ptr is a SQLSMALLINT*; SQL_DESC_PRECISION is
stored as
+ // a SQLSMALLINT. Pass the matching buffer size.
Review Comment:
Likewise for this comment.
##########
cpp/src/arrow/flight/sql/odbc/odbc_api.cc:
##########
@@ -1603,8 +1609,10 @@ SQLRETURN SQLDescribeCol(SQLHSTMT stmt, SQLUSMALLINT
column_number, SQLWCHAR* co
case SQL_BIGINT:
case SQL_DECIMAL:
case SQL_NUMERIC: {
+ // decimal_digits_ptr is a SQLSMALLINT*; SQL_DESC_SCALE is stored as
a
+ // SQLSMALLINT. Pass the matching buffer size.
Review Comment:
While this comment helps explain the reasoning behind the change to anyone
looking at this PR, I don't think this comment is particularly helpful after
the change gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
