mroeschke commented on code in PR #50409:
URL: https://github.com/apache/arrow/pull/50409#discussion_r3641680303
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -690,9 +690,9 @@ Status AppendUTF32(const char* data, int64_t itemsize, int
byteorder, T* builder
return Status::Invalid("failed converting UTF32 to UTF8");
}
- const int32_t length =
static_cast<int32_t>(PyBytes_GET_SIZE(utf8_obj.obj()));
+ const int32_t length = static_cast<int32_t>(PyBytes_Size(utf8_obj.obj()));
Review Comment:
Sure in b1b1e7284a73c80cfc9d6ca1840e3190f41e862a I defined
`PyBytes_AsStdStringView` in `helpers.cc` and used it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
