amoeba commented on PR #4585: URL: https://github.com/apache/arrow-adbc/pull/4585#issuecomment-5073687387
This looks good to me. I compared the wheel filenames between a run with and without this change. CI run before: https://github.com/apache/arrow-adbc/actions/runs/30089666671/job/89469920732 CI run with this PR: https://github.com/apache/arrow-adbc/actions/runs/30118343805/job/89564523415 In each CI run, I downloaded the artifacts from the "Archive wheels" step and compared them to show this PR fixes the filename inconsistency: ```sh # without this change $ ls -1 python-amd64-manylinux-before/adbc_driver_manager/repaired_wheels/ adbc_driver_manager-1.12.0.dev0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0.dev0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0.dev0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0.dev0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0.dev0-cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0.dev0-cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl # with this change, wheels no longer have `.dev0` $ ls -1 python-amd64-manylinux-after/adbc_driver_manager/repaired_wheels/ adbc_driver_manager-1.12.0-cp310-cp310-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0-cp311-cp311-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0-cp312-cp312-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0-cp313-cp313-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0-cp314-cp314-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl adbc_driver_manager-1.12.0-cp314-cp314t-manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
