kou commented on code in PR #50587: URL: https://github.com/apache/arrow/pull/50587#discussion_r3648281579
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -410,6 +410,15 @@ if(ARROW_AZURE) set(ARROW_WITH_AZURE_SDK ON) endif() +# The macOS 11.3 SDK has incomplete C++20 concepts support, which prevents +# simdjson headers from compiling. Disable simdjson concepts for this SDK. +if(ARROW_JSON + AND CMAKE_OSX_SYSROOT + AND CMAKE_OSX_SYSROOT MATCHES "MacOSX11\\.3\\.sdk$") + message(STATUS "Disabling simdjson concepts for macOS SDK 11.3") + add_compile_definitions(SIMDJSON_CONCEPT_DISABLED=1) +endif() Review Comment: @Reranko05 Could you move this to `build_simdjson()` and use `target_compile_options()` instead of `add_compile_definitions()` as a follow-up task? Could you report this to upstream? Upstream also checks clang version but we need to SDK version not clang version. https://github.com/simdjson/simdjson/blob/8e6bac94877f2d3d026000d36ce81e0aaf38d26f/include/simdjson/compiler_check.h#L83-L87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
