fallintoplace opened a new pull request, #996: URL: https://github.com/apache/arrow-go/pull/996
### Rationale for this change The bloom filter sizing formula produces a bit count, but the maximum-size comparison converted the byte limit in the wrong direction. As a result, an otherwise modest filter could jump directly to the 128 MiB cap. ### What changes are included in this PR? Compare the calculated bit count with the maximum byte size converted to bits. Update the cap test and add coverage for a filter whose optimal size is between 2 MiB and the maximum. ### Are these changes tested? Yes. go test ./parquet/metadata ### Are there any user-facing changes? Bloom filters sized from NDV and false-positive probability no longer grow to 128 MiB prematurely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
