fallintoplace opened a new pull request, #999:
URL: https://github.com/apache/arrow-go/pull/999

   ### Rationale for this change
   
   Tensor constructors document that nil dimension names are replaced by empty 
strings. The common constructor retained nil instead, so DimName panicked for 
an otherwise valid tensor.
   
   ### What changes are included in this PR?
   
   Initialize one empty name per dimension when names is nil and add coverage 
for DimNames and DimName.
   
   ### Are these changes tested?
   
   Yes. go test ./arrow/tensor
   
   ### Are there any user-facing changes?
   
   Tensors constructed with nil names now return empty dimension names as 
documented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to