bit2swaz opened a new pull request, #10433:
URL: https://github.com/apache/arrow-rs/pull/10433

   # Which issue does this PR close?
   
   No separate issue. The fix is one line per test case and the failing CI runs 
are evidence enough.
   
   # Rationale for this change
   
   MIRI CI uses nightly Rust. A recent nightly changed the `Display` output of 
`TryFromIntError` from `"out of range integral type conversion attempted"` to 
`"number too large to fit in target type"` (and similar variants). Tests in 
`datatype_parse.rs` were asserting on that stdlib-owned suffix, so they broke 
on MIRI without any change to our code.
   
   # What changes are included in this PR?
   
   Trimmed 9 expected substrings in `parse_data_type_errors` to stop at the `:` 
that separates our message from the stdlib one. The tests now only assert on 
the part of the error string we control.
   
   # Are these changes tested?
   
   `parse_data_type_errors` passes on stable. MIRI CI should go green once this 
merges.
   
   # Are there any user-facing changes?
   
   No. Test-only change, no behavior or API impact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to