fallintoplace opened a new pull request, #1006: URL: https://github.com/apache/arrow-go/pull/1006
### Rationale for this change INT96 timestamp conversion currently routes values through `time.Duration` and applies a nanoseconds-per-day modulus directly to the source value. This produces incorrect results for second, millisecond, and microsecond timestamps, overflows for timestamps outside the duration range, and leaves negative timestamps with a negative time-of-day remainder. ### What changes are included in this PR? - Convert each Arrow timestamp unit using integer units-per-day and nanoseconds-per-unit constants. - Normalize negative remainders onto the preceding Julian day. - Add focused coverage for every timestamp unit on both sides of the Unix epoch. ### Are these changes tested? Yes. The focused pqarrow tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
