PG1204 commented on PR #1249: URL: https://github.com/apache/arrow-java/pull/1249#issuecomment-5079442442
> Seems reasonable. From what I was researching, doesn't seem like it is a leak easy to hit and it may only leak a few KBs. > > I'd probably just try to add a test that reproduces the issue an ensure that it passes with the fix @xborder Agreed it's low-impact and hard to hit. I've added a regression test (TestFromSchemaByteArray) that feeds malformed schema bytes to the native createDataset path, which is the exact branch that used to skip ReleaseByteArrayElements, and confirms it now fails gracefully with the fix in place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
