fallintoplace opened a new pull request, #1020:
URL: https://github.com/apache/arrow-go/pull/1020

   ### Rationale for this change\n\nListBuilder.AppendValues can accept 
malformed offset counts and ranges. NewArray then appends a final offset for 
any count mismatch and can return arrays with undersized, non-monotonic, or 
out-of-bounds offset buffers. Reading or validating those arrays can fail 
later.\n\n### What changes are included in this PR?\n\n* Require supplied 
offsets to contain either one entry per list or one entry per list plus the 
final offset.\n* Reject negative, out-of-bounds, and non-monotonic offsets for 
List and LargeList builders.\n* Continue allowing valid trailing child values 
that are not referenced by the list offsets.\n\n### Are these changes 
tested?\n\nYes. The tests cover too few and too many offsets, negative offsets, 
non-monotonic offsets, and final offsets beyond the child array for both offset 
widths. The full arrow/array package, assertion build, compute packages, IPC 
package, and CSV package also pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to