alamb commented on code in PR #10364:
URL: https://github.com/apache/arrow-rs/pull/10364#discussion_r3651204835
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1837,93 +1833,111 @@ fn get_interval_dt_array_slice(
array: &arrow_array::IntervalDayTimeArray,
indices: impl ExactSizeIterator<Item = usize>,
) -> Vec<FixedLenByteArray> {
- let mut values = Vec::with_capacity(indices.len());
- for i in indices {
- let mut out = [0; 12];
+ chunk_array_slice(12, indices, move |i, chunk| {
let value = array.value(i);
- out[4..8].copy_from_slice(&value.days.to_le_bytes());
- out[8..12].copy_from_slice(&value.milliseconds.to_le_bytes());
- values.push(FixedLenByteArray::from(ByteArray::from(out.to_vec())));
+ chunk[4..8].copy_from_slice(&value.days.to_le_bytes());
+ chunk[8..12].copy_from_slice(&value.milliseconds.to_le_bytes());
+ })
+}
+
+trait NativeDecimalType: DecimalType {
Review Comment:
Maybe we could just add these to the DecimalType trait itself (rather than a
private trait) -- perhaps as a follow on PR
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -1821,14 +1821,10 @@ fn get_interval_ym_array_slice(
array: &arrow_array::IntervalYearMonthArray,
indices: impl ExactSizeIterator<Item = usize>,
) -> Vec<FixedLenByteArray> {
- let mut values = Vec::with_capacity(indices.len());
- for i in indices {
- let mut value = array.value(i).to_le_bytes().to_vec();
- let mut suffix = vec![0; 8];
Review Comment:
that is indeed an expensive way to append 8 bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
