Rich-T-kid commented on PR #10440: URL: https://github.com/apache/arrow-rs/pull/10440#issuecomment-5086083833
> looking at these now, i wonder if we omitted having these because it only really skips some constant checks (i.e. we're not validating per element, we just have some cheap len checks) 🤔 > > especially for primitive & boolean arrays, maybe having less of a surface area is actually better since we're just skipping a single len check (well option + len check) > > thoughts? @Jefffrey yea I generally agree with having less of an api surface, especially in this case where we would force callers to have unsafe blocks for minimal value. i'm not entirely opposed to the idea of keeping these methods to fit in with all of the other array `new_unchecked()` methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
