Rich-T-kid commented on issue #8879: URL: https://github.com/apache/arrow-rs/issues/8879#issuecomment-5086286171
@Dandandan is this a stale issue? I see that [take_record_batch()](https://docs.rs/arrow-select/59.1.0/src/arrow_select/take.rs.html#1121) currently passes no options into each take call. [TakeOption](https://docs.rs/arrow-select/59.1.0/src/arrow_select/take.rs.html#391) has a boolean to skip the bounds checks. wouldn't the simplest solution be to allow for callers to inject this `TakeOption` and in datafusion we can set the `check_bounds` to false to avoid un-needed checks. Also each[ array in a record batch has the same number of values](https://docs.rs/arrow/latest/arrow/record_batch/struct.RecordBatch.html) so we can guarantee theres no out of bounds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
